privsep patch, Please test (take 3)

[Joshua Hill]

On Wed, Jun 05, 2002 at 06:22:39PM -0700, Tim Rice wrote:
> Here is the version I'll commit to CVS if there are no objections.

Just a quick heads up; I get a segfault when I run the daemon
with PrivilegeSeparation.  The last few lines of the strace
output is

---snip---
write(2, "debug1: Client protocol version "..., 78debug1: Client protocol version 2.0; client software version OpenSSH_2.5.2p2^M
) = 78
write(2, "debug1: match: OpenSSH_2.5.2p2 p"..., 81debug1: match: OpenSSH_2.5.2p2 pat OpenSSH_2.5.0*,OpenSSH_2.5.1*,OpenSSH_2.5.2*^M
) = 81
write(2, "Enabling compatibility mode for "..., 46Enabling compatibility mode for protocol 2.0^M
) = 46
write(2, "debug1: Local version string SSH"..., 55debug1: Local version string SSH-1.99-OpenSSH_3.2.3p1^M
) = 55
fcntl(4, F_SETFL, O_RDONLY|O_NONBLOCK)  = 0
socketpair(PF_UNIX, SOCK_STREAM, 0, [3, 7]) = 0
fcntl(3, F_SETFD, FD_CLOEXEC)           = 0
fcntl(7, F_SETFD, FD_CLOEXEC)           = 0
--- SIGSEGV (Segmentation fault) ---
+++ killed by SIGSEGV +++

---snip---

The stack trace for the process (just after the segfault) is:

#0  memset (dstpp=0x2, c=208, len=128) at ../sysdeps/i386/memset.c:57
#1  0x805980e in mm_malloc (mm=0x808f1e8, size=28) at monitor_mm.c:190
#2  0x8059781 in mm_xmalloc (mm=0x808f1e8, size=28) at monitor_mm.c:162
#3  0x8059679 in mm_create (mmalloc=0x808f1e8, size=1310720) at monitor_mm.c:78
#4  0x805b9fd in monitor_init () at monitor.c:1486
#5  0x804c636 in privsep_preauth () at sshd.c:569
#6  0x804dba4 in main (ac=9, av=0xbffffab4) at sshd.c:1450


This is on a RedHat Linux 6.2 box, with glibc 2.1.3 and kernel 2.2.19.

I'll look into this more this evening...

				Josh