AIX usrinfo() cleanup.

[Ben Lindstrom]

On Fri, 28 Jun 2002, Sandor W. Sklar wrote:

> At 12:03 PM -0500 6/28/02, Ben Lindstrom wrote:
> >Can we do this?  Or should we drop the whole char *tty; ?  There will
> >be no way of setting the TTY= correctly while  using privsep (Mainly for
> >multiple streams over single session).
>
> Forgive a stupid question, but what is the implication of this?  My
> possibiily incorrect understanding is that if it isn't set by
> OpenSSH, it can be set by "login" if UseLogin is set to yes.
>
> Sorry, but I'd like to understand what changes I might have to expect.
>
> Thanks,
> -S-
>

The issue is by time usrinfo() is called we have lost root privs.  The
temporary solution for 3.4 was to set everything but TTY= since we don't
know it at that time.

If one needs TTY= it can easily be added back into do_child().

That is my current question.  Outside the simple clean up of passing the
TTY only instead of both tty and ttyfd.  (since we can do the same things
by doing  's->ttyfd == -1 ? NULL : s->tty'

Should we add in a non-privsep case where TTY= will be set in do_child().
That way people who need TTY can still run OpenSSH without uselogin.

We are refering to usrinfo() setting TTY=.  So unless you have older
applications that require it.  You will not be affected either way.