3.1p1 breaks X11 forwarding

[Pekka Savola]

On Tue, 12 Mar 2002, Kevin Steves wrote:
> On Tue, 12 Mar 2002, Pekka Savola wrote:
> :Just as heads-up: On all-Linux systems, the necessity X11UseLocalhost=no
> :(in some, more complex scenarios)  also depends on whether IPv6 is enabled
> :in sshd or not.
> :
> :I've yet to corner down what's causing this but I've seen a few cases
> :that:
> :
> :(assuming X11UseLocalhost yes is the default)
> :WORKS: sshd -4
> :WORKS: sshd -o 'X11UseLocalhost no'
> :DOESN'T WORK: sshd
> :
> :(the application used was xterm).
> :
> :If this doesn't happen without Linux, it may be due to the Linux
> :mapped-address implementation.
> :
> :I believe this will also have to do with the fact whether IPv6 has been
> :enabled in X11 along the path.
> 
> strange. i was thinking of doing the following a while back, but IPv6 X11
> is apparently on the horizon, so we left it.  are your X clients IPv6
> capable?

The clients I've used are IPv4-only.  I also heard a (vague) report that
from a FreeBSD client this would have worked slightly betterm but I can't
confirm that.

I hope to be able to figure out why this appears to work in some cases, 
and not in others, but I'm not sure if I'll have that much luck...

> Index: channels.c
> ===================================================================
> RCS file: /cvs/src/usr.bin/ssh/channels.c,v
> retrieving revision 1.146
> diff -u -r1.146 channels.c
> --- channels.c	6 Dec 2001 18:20:32 -0000	1.146
> +++ channels.c	7 Dec 2001 18:56:35 -0000
> @@ -2411,7 +2411,7 @@
>  	     display_number++) {
>  		port = 6000 + display_number;
>  		memset(&hints, 0, sizeof(hints));
> -		hints.ai_family = IPv4or6;
> +		hints.ai_family = AF_INET;
>  		hints.ai_flags = gateway_ports ? AI_PASSIVE : 0;
>  		hints.ai_socktype = SOCK_STREAM;
>  		snprintf(strport, sizeof strport, "%d", port);
> 
> 
> 

-- 
Pekka Savola                 "Tell me of difficulties surmounted,
Netcore Oy                   not those you stumble over and fall"
Systems. Networks. Security.  -- Robert Jordan: A Crown of Swords