[PATCH] Allow "ProxyCommand none" in ssh_config

Ben Lindstrom mouring at etoh.eviladmin.org
Tue Oct 1 07:05:14 EST 2002


On Mon, 30 Sep 2002, Thomas Binder wrote:

> Hi!
>
> As discussed in the thread "Question regarding patch for
> ProxyCommand setting".
>
> The patch is rather straight forward; maybe it would be a good
> idea to improve it in a way that it uses a list of string options
> that may have a "none" value to reset it to NULL.
>

Ugh..I was expecting something closer to where all the argument processing
happens.

Like below (don't 'whinge'  I have not even compiled it.  Just an
example).

- Ben


Index: readconf.c
===================================================================
RCS file: /cvs/src/usr.bin/ssh/readconf.c,v
retrieving revision 1.100
diff -u -r1.100 readconf.c
--- readconf.c	19 Jun 2002 00:27:55 -0000	1.100
+++ readconf.c	30 Sep 2002 19:38:09 -0000
@@ -491,7 +491,11 @@
 			strcat(string, arg);
 		}
 		if (*activep && *charptr == NULL)
-			*charptr = string;
+			if (strcmp(arg, "none") == 0) {
+				*charptr == NULL
+				xfree(string);
+			} else
+				*charptr = string;
 		else
 			xfree(string);
 		return 0;




More information about the openssh-unix-dev mailing list