Patch so that sshd makes use of PAM_USER

Jeremy Ellington jeremy.ellington at newisys.com
Wed Sep 4 01:24:24 EST 2002


I think I have it down now. ;-)

Thanks.  BTW, what do I have to do to actually get this merged?

-----Original Message-----
From: Ben Lindstrom [mailto:mouring at etoh.eviladmin.org]
Sent: Friday, August 30, 2002 11:50 PM
To: Jeremy Ellington
Subject: RE: Patch so that sshd makes use of PAM_USER



You're still not following:

http://www.openbsd.org/cgi-bin/man.cgi?query=style

Which makes is much harder to read and make all the portable developers
less likely to even read the patch much less apply it since we then have
to go back and fix it.

General rules:

* Tab for blocks
* If you span two lines 4 spaces are used to indent the second line.
* avoid using { } if you don't have two or more clauses or where you
are doing multiple if () near each other and the compiler/read could
become confused.

Also, the rule of thumb for portable is make the least amount of impact on
the code.   Otherwise it makes my life an utter hell when doing CVS syncs.

- Ben


-------------- next part --------------
A non-text attachment was scrubbed...
Name: pam_user.diff
Type: application/octet-stream
Size: 4119 bytes
Desc: pam_user.diff
Url : http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20020903/53d610f1/attachment.obj 


More information about the openssh-unix-dev mailing list