[PATCH re-send]: Clean up logging of failed logins

[Darren Tucker]

Ben Lindstrom wrote:
> Just rename cray_login_failure() and loginfailed() to
> record_failed_login(), and change the #ifdef WITH_AIXAUTHENTICATE to
> #ifdef CUSTOM_LOGIN_FAILURE.
> 
> That way we can just #define CUSTOM_LOGIN_FAILURE in the aix/cray headers
> to activate it and we can keep things cleaner.

I just had a quick look.  To this, both functions will need 4 arguments, 2
extraneous on Cray, 1 on AIX.  What if the next platform that has this
functionality needs another argument?  Plus there's an extra #ifdef in the
mainline.

Are you sure that's cleaner?

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.