[PATCH re-send]: Clean up logging of failed logins

[Darren Tucker]

Ben Lindstrom wrote:
> On Mon, 28 Apr 2003, Darren Tucker wrote:
> > Is the attached patch better?  Tested on AIX 4.3.3.
>
> Outside of being a bit too #ifdef happy in port-aix.c =)  Looks good.

Man, some people are never happy :-).

Seriously, the #ifdef CUSTOM_FAILED_LOGIN is there for a reason. 
WITH_AIXAUTHENTICATE acts as a flag for all of the AIX authentication
routines, including loginfailed().  It's possible to build for AIX without
WITH_AIXAUTHENTICATE, in that case CUSTOM_FAILED_LOGIN won't be defined
and we shouldn't use loginfailed().

Whether or not there are any AIXes that don't have loginfailed() is
another matter.  At one point we didn't link in the library on 4.2.x that
held authenticate() and friends, so WITH_AIXAUTHENTICATE was not defined
there.  It's possible that older ones don't have it at all.

> I'll add it to the list of commits I have for portable.

Thanks.

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.