progressmeter.c fails to build on Cygwin

[Corinna Vinschen]

Hi,

I didn't had the time to build portable OpenSSH from CVS for some weeks
now.  I was very surprised to see that it fails to build on Cygwin.
It only fails in the new progressmeter.c file which has two flaws:

First of all, libgen.h and basename() don't exist on Cygwin (and probably
on other systems).  I already implemented this function in the
bsd-cygwin_util.c file but I'd think it could make sense to put it
into some other file since it's probably needed for other systems, too.
Does anybody know of other systems?  Otherwise I'll send a patch which
defines it only for Cygwin.

But especially, I don't see a reason why the good old foregroundproc()
function unconditionally uses ioctl(TIOCGPGRP) now instead of testing for
HAVE_TCGETPGRP as before, when the function was in scp.c.  Worse, the
test for tcgetpgrp has been removed from configure.ac.  This definitely
is a showstopper for Cygwin.  I reverted the patch in my local sandbox
already and it builds again.  I'd like to know if I should send the
patch or if it's not needed.


Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:vinschen at redhat.com