[PATCH] Password expiry merge (AIX parts)

[Ben Lindstrom]

One comment, and one question on the patch itself.

auth-passwd.c change that needs to be fixed:

[..]
+#include "buffer.h"
 #include "openbsd-compat/xcrypt.h"
 #ifdef WITH_AIXAUTHENTICATE
 # include "buffer.h"
[..]

Please remove the one inside the WITH_AIXAUTHENTICATE.  And I assume your
pulling them back out for the generalization for all platforms.


in auth.c you make the comment "if not running as root don't check because
the unpriv'd does not have rights to /etc/[..]".

Does that mean with PrivSep inplace that code will never be ran?  If so
why?  and is it not important?

On Wed, 30 Jul 2003, Darren Tucker wrote:

> Hi All.
> 	Attached is a patch introduces password expiry handling for AIX (other
> platforms to follow).  It is more or less the same as the previous patch
> but has been updated to reflect recent changes to auth-passwd.c
>
> 	I'm wondering if the AIX parts of auth.c should be moved to port-aix.c
> and if the generic password change functions (currently at the end of
> auth-passwd.c) belong in a separate file (eg pwchange.c).
>

If it makes sense and can clean up code please move the AIX code. =)

> 	Comments?  Objections?  Any volunteers to look this one over?
>

I'd like to see the change password code go upstream before integrated in
our tree.

- Ben