patch20 fails

[Darren Tucker]

rrr55 at daimlerchrysler.com wrote:
> I am using GNU patch.  I used the source from openssh.org from apr 29th.  I
> realized that I was using a version that I had patched.  I started again
> w/fresh source and the patch was successful, but now compilation fails
> w/auth.c.  Prior versions had no problems patching/compiling.
> ==========================
> 
> In file included from auth.c:41:
[snip]
> auth.c:630: too few arguments to function `loginfailed'
> auth.c: In function `auth_debug_add':

You're using AIX 5.2, right?  As of 5.2, loginfailed() takes a 4th
argument.  For a discussion and quick fix, see  
http://marc.theaimsgroup.com/?l=openssh-unix-dev&m=105223097117841

That 4th argument seems to be optional.  At some point I added the
#include that defined loginfailed, which is why it now breaks.

I guess I should have configure test for and define AIX_LOGINFAILED_4ARGS,
and add an ugly #ifdef...

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.