[Bug 517] bad "put" arg parsing

bugzilla-daemon at mindrot.org bugzilla-daemon at mindrot.org
Tue Mar 25 12:55:31 EST 2003


http://bugzilla.mindrot.org/show_bug.cgi?id=517





------- Additional Comments From jason at devrandom.org  2003-03-25 12:55 -------
The above patch replaces strchr with strrchr so that the get_pathname will look
for the last ' or " for the filepath and not the first " or ' it comes to.

Test/Proof:

(Current SFTP)

sftp> dir
silly""file''2
this"is' asillyname
sftp> get "silly\"\"file\'\'2"
Couldn't stat remote file: No such file or directory
File "/home/jason/silly\" not found.
sftp> get "thCouldn't stat remote file: No such file or directory
File "/home/jason/this\" not found.
is\"is\' asillyname"


(Patched SFTP)

sftp> dir
silly""file''2
sftp> get "silly\"\"file\'\'2"
silly""file''2                                100%    3     0.4KB/s   00:00
Fetching /home/jason/this"is' asillyname to this"is' asillyname
sftp> exit

Only thing is that the filename seems to mess up the progress meter.  This
changed didn't seem to break any fetches and solves every " or ' problem I could
throw at it.




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.




More information about the openssh-unix-dev mailing list