get_pin for scard-opensc.c

[Kevin Stefanik]

Forgot the list...

----------  Forwarded Message  ----------

Subject: Re: get_pin for scard-opensc.c
Date: Friday 09 May 2003 09:41 am
From: Kevin Stefanik <kstef at mtppi.org>
To: Markus Friedl <markus at openbsd.org>

On Thursday 08 May 2003 06:21 pm, you wrote:
> +   sprintf (buf, "Enter PIN [%s]: ", obj->label);
>
> never ever use sprintf, please.

Thank you for your polite restraint.

Kevin

PS: I also fixed a possible memory leak on sc_pin if pin verification failed.

-------------------------------------------------------


-------------- next part --------------
A non-text attachment was scrubbed...
Name: openssh-3.5p1-opensc-get_pin.patch
Type: text/x-diff
Size: 2443 bytes
Desc: not available
Url : http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20030509/13df4835/attachment.bin