New PAM code landing (at last)

[Dag-Erling Smorgrav]

Damien Miller <djm at mindrot.org> writes:
> Also note that we do not enable and have no intention of enabling the
> thread support - we don't want the complexity of theads in the monitor.
> The code is still there at the moment (#ifdef'd out), but will likely
> disappear from our tree in the future. I'll try to remove it in such a
> way that the FreeBSD developers don't end up in #ifdef hell putting it
> back in their tree.

There's nothing to remove.  Unless you define USE_POSIX_THREADS, the
PAM code will use a child process instead of threads.  At most, you
may want to remove the following lines:

#ifdef USE_POSIX_THREADS
#include <pthread.h>
#else

and, further down:

#endif

as well as one instance of #ifndef USE_POSIX_THREADS.

Also, please make sure that -

 - you are using the latest PAM code from FreeBSD-CURRENT
 - you also have my auth-chall.c patches
 - you also have the abandon_challenge_response() patch for auth1.c
 - you remove the PAMAuthenticationViaKbdInt option from servconf.c
 - you run #unifdef -UUSE_PAM on auth-passwd.c

DES
-- 
Dag-Erling Smorgrav - des at ofug.org