[Bug 559] PAM fixes

[bugzilla-daemon at mindrot.org]

http://bugzilla.mindrot.org/show_bug.cgi?id=559





------- Additional Comments From djm at mindrot.org  2003-05-14 10:23 -------
> @@ -186,8 +186,8 @@ input_userauth_request(int type, u_int32
>  	m = authmethod_lookup(method);
>  	if (m != NULL) {
>  		debug2("input_userauth_request: try method %s", method);
> -		authenticated =	m->userauth(authctxt);
> +		authenticated = m->userauth(authctxt) && authctxt->valid;
>  	}
>  	userauth_finish(authctxt, authenticated, method);

This chunk is not necessary, as userauth_finish does:

> 	if (!authctxt->valid && authenticated)
> 		fatal("INTERNAL ERROR: authenticated invalid user %s",
> 		    authctxt->user);

and no auth method should set authenticated = 1 for a non existant user :)




------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.