Changes in tonights snapshot

[Darren Tucker]

Damien Miller wrote:
> Please report problems with any of the above to bugzilla or this list.

It looks like the SOCK_STREAM -> ai_socktype change broke AIX (at least
4.2.1, 4.3.3 & 5.1, possibly others), which was caught by the
tinderbox[1].  I don't know why yet, I'll do some digging.  I did notice
that AIX defines BROKEN_GETADDRINFO.

		-Daz.

# ./sshd -ddd -p 2022
[snip]
debug1: private host key: #2 type 2 DSA
socket: Protocol not supported
Cannot bind any address.

# cvs diff -r 1.239 -r 1.240 sshd.c
[snip]
-	listen_sock = socket(ai->ai_family, SOCK_STREAM, 0);
+	listen_sock = socket(ai->ai_family, ai->ai_socktype,
+	    ai->ai_protocol);

# cvs up -r 1.239 sshd.c && make sshd
P sshd.c
[snip]

# ./sshd -ddd -p 2022
[snip]
debug1: private host key: #2 type 2 DSA
debug1: Bind to port 2022 on 0.0.0.0.
Server listening on 0.0.0.0 port 2022.
Generating 768 bit RSA key.
RSA key generation complete.

[1] http://dodgynet.dyndns.org/tinderbox/OpenSSH_Portable/status.html

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.