Changes in tonights snapshot

[Damien Miller]

Darren Tucker wrote:
> Darren Tucker wrote:
>> Damien Miller wrote:
>> > Please report problems with any of the above to bugzilla or this list.
>> 
>> It looks like the SOCK_STREAM -> ai_socktype change broke AIX (at least
>> 4.2.1, 4.3.3 & 5.1, possibly others), which was caught by the
>> tinderbox[1].  I don't know why yet, I'll do some digging.  I did notice
>> that AIX defines BROKEN_GETADDRINFO.
> 
> Further info: same thing happens on Solaris 7 (which also doesn't have
> getaddrinfo at all so also uses fake-getaddrinfo.c).  Adding some
> debugging to sshd, I get:
> 
> debug1: private host key: #2 type 2 DSA
> debug3: setting up socket, ai_family 2 ai_socktype 0 ai_protocol 0
> socket: Protocol not supported
> Cannot bind any address.
> 
> How about setting "ai->ai_socktype = SOCK_STREAM;" to malloc_ai()?  This
> works for me.

If hints->ai_socktype and hints->ai_protocol are set we should use them
first, otherwise you are correct*.

-d

* for our purposes, but woe betide any who try to use our getaddrinfo
implementation elsewhere