OpenSSH 3.7 testing (Re: 3.6p1 bug on SCO OpenServer)

[Wendy Palm]

i'm getting a fatal compiler error in do_upload() in sftp-client.c -

CC-167 cc: WARNING File = sftp-client.c, Line = 1046
   Argument of type "u_int64_t *" is incompatible with parameter of type "off_t *"
           .

                 start_progress_meter(local_path, sb.st_size, &offset);

due to offset being defined as u_int64_t rather than off_t.

off_t on the machines i checked is signed, and other calls to start_progress_meter in
other functions seem to be correct.

% diff -c sftp-client.c.orig sftp-client.c
*** sftp-client.c.orig  Mon Sep  8 16:22:30 2003
--- sftp-client.c       Mon Sep  8 16:34:06 2003
***************
*** 974,980 ****
   {
         int local_fd, status;
         u_int handle_len, id, type;
!       u_int64_t offset;
         char *handle, *data;
         Buffer msg;
         struct stat sb;
--- 974,980 ----
   {
         int local_fd, status;
         u_int handle_len, id, type;
!       off_t offset;
         char *handle, *data;
         Buffer msg;
         struct stat sb;
***************
*** 984,990 ****
         struct outstanding_ack {
                 u_int id;
                 u_int len;
!               u_int64_t offset;
                 TAILQ_ENTRY(outstanding_ack) tq;
         };
         TAILQ_HEAD(ackhead, outstanding_ack) acks;
--- 984,990 ----
         struct outstanding_ack {
                 u_int id;
                 u_int len;
!               off_t offset;
                 TAILQ_ENTRY(outstanding_ack) tq;
         };
         TAILQ_HEAD(ackhead, outstanding_ack) acks;

Ben Lindstrom wrote:

> On this note I think it would be best to opening the floor for testing of
> the current CVS tree.  OpenSSH is in a feature lock and we should be in
> in sync with the OpenBSD tree (there may be stray patches, but hopefully
> nothing major).
> 
> So please if we can get people to start doing tests on their platform is
> would help.
> 
> The major things that have changed is PAM and Kerb/GSS support.  However,
> we did do a clean up of openbsd-compat/ code so I may have broken
> platforms I don't own by playing in there.  I also redid how we handle
> signal (signal() vs a stricter mysignal() version).  So that is something
> to watch out for (basicly made it consistant).
> 
> There are a bunch more changes, but I don't have a copy of the proposed
> release notes sitting in front of me.
> 
> BTW, regression testing should hopefully work for most platforms.  Please
> get in the habbit of using this.  It should give us a better handle on
> platform breakage.  Darren was nice enough to get that rolling recently.
> 
> It should be as simple as ./configure [needed options] && make && make
> tests, but I've not had a chance to confirm it with an actually test on my
> Solaris test box.
> 
> Sooooo... If you wish your platform to work then drop by
> http://www.openssh.com/portable.html, pick your favorate ftp server
> or grab the the source from the CVS tree.
> 
> Thanks,
> 
> - Ben && The OpenSSH Portable Team



-- 
wendy palm
Cray Open Software Development, Cray Inc.
wendyp at cray.com, 651-605-9154