Variable declarations in xcrypt.c

Darren Tucker dtucker at zip.com.au
Tue Sep 9 12:12:39 EST 2003


Ben Lindstrom wrote:
> On Mon, 8 Sep 2003, Darren Tucker wrote:
> >       I noticed that xcrypt.c now has some variable declarations after code
> > within a block (for some sets of #ifdef's).  Won't that choke some
> > compilers?  Should it do something like the attached?
> >
> 
> Well.. the first #ifdef will never be triggered with the second set.  You
> can't set shadowed and HAVE_GETPWANAM.  So it should be safe as it is.
> However maybe it should be an #elif instead of a #endif #if ..

I was thinking of it from the POV of removing DISABLE_SHADOW for HP-UX
(Bug #633) but leaving the __hpux section there to support older versions
(I'm not sure about that, Kevin has said he'll look at it).

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.




More information about the openssh-unix-dev mailing list