OpenSSH 3.7 testing (Re: 3.6p1 bug on SCO OpenServer)

[Damien Miller]

Ben Lindstrom wrote:
> 
> On Tue, 9 Sep 2003, Darren Tucker wrote:
> 
> 
>>Wendy Palm wrote:
>>
>>>i'm getting a fatal compiler error in do_upload() in sftp-client.c -
>>>
>>>CC-167 cc: WARNING File = sftp-client.c, Line = 1046
>>>   Argument of type "u_int64_t *" is incompatible with parameter of type "off_t *"
>>>           .
>>>
>>>                 start_progress_meter(local_path, sb.st_size, &offset);
>>>
>>>due to offset being defined as u_int64_t rather than off_t.
>>>
>>>off_t on the machines i checked is signed, and other calls to start_progress_meter in
> 
> 
> Eep.. am I the only one that thinks that is wrong? =)  off_t signed?
> sounds like a bad deal.

IIRC off_t should be signed - one must be able to specify negative file 
offsets for things like lseek() with SEEK_CUR or SEEK_END. OpenBSD i386 
typedefs it to "long long".

-d