OpenSSH 3.7 testing (Re: 3.6p1 bug on SCO OpenServer)

Ben Lindstrom mouring at etoh.eviladmin.org
Sun Sep 14 09:56:27 EST 2003



On Sat, 13 Sep 2003, Brian Poole wrote:

[..]
> Commenting that line out gives me (obviously not acceptable for the
> real solution, just wanting to see if that was a separate problem):
>
> $ cvs diff -u Makefile
> Index: Makefile
> ===================================================================
> RCS file: /cvs/openssh/regress/Makefile,v
> retrieving revision 1.8
> diff -u -r1.8 Makefile
> --- Makefile    9 Sep 2003 13:07:10 -0000       1.8
> +++ Makefile    13 Sep 2003 23:31:51 -0000
> @@ -1,6 +1,6 @@
>  #      $OpenBSD: Makefile,v 1.24 2003/07/03 08:24:13 markus Exp $
>
> -OBJ ?= `pwd`
> +# OBJ ?= `pwd`
>

Hmm.. This is required for building outside of the tree.  Tim or someone
that does this will have to address this.  I don't normally.

[..]
> So.. #1 is still a problem, perhaps someone better versed with Makefiles
> can fix it. I'm getting twitchy just fiddling with it ;-). #2 seems to be
> fixed by adding white space, though I'm suspicious that clean & distclean
> are cleaning the exact same set of files. Is this correct? Why are there
> two assignment statements if it is supposed to be always cleaning the
> same set of files?
>

In general the patch looks sane.  Outside of the above comment about OBJ.

As for clean and distclean being the same.  That is fine.  'clean' is
normally used between 'make && make install'.  'distclean' actually
strips out stuff that 'make -f Makefile.in distprep' does.  So it should
bring it close to the same state as if you'd pull it from the CVS tree.

Since 'make -f Makefile.in distprep' does not do any work in regress/ tree
they are extactly the same.  Some day down the road this may change.

- Ben




More information about the openssh-unix-dev mailing list