OpenSSH 3.7 testing (Re: 3.6p1 bug on SCO OpenServer)

[Darren Tucker]

Brian Poole wrote:
> It appears that the regress Makefile is not portable enough. Solaris
> make in particular pukes on it currently (GNU make works fine.)

> make: Fatal error: Command failed for target `clean'

It's just the "clean" target, not the tests themselves?  I'll take a look
at that.

> The regress suite looks good, a big thanks for getting it working. My
> nit here is that I think the yes-head test should verify that yes exists
> before it tries to use it.

We fixed that a day or two ago.  "yes" is not used now.

I didn't realise it wasn't on Solaris until recently (I have GNU sh-utils
on mine), then replaced it with the equivalent do-while loop.

That proptly broke for people using csh as their login shell.  Sigh.  Tim
fixed that, so now instead of 'yes', we use the more portable but much
less readable 'sh -c "while true;do echo yes; done"'.  Don't you love
portable shell scripting?

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.