Code question (canohost.c)

Damien Miller djm at mindrot.org
Fri Apr 30 11:53:40 EST 2004


Ben Lindstrom wrote:

> 
> 
> On Thu, 29 Apr 2004, John Devitofranceschi wrote:
> 
> 
>>So, I looked at some older versions of the code and found that, indeed, a
>>NULL was sent as the second parameter in previous releases.
>>
> The code never existed before this patch was added.
> 
> http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/canohost.c.diff?r1=1.36&r2=1.37

I think the use of "0" instead of NULL is wrong, but I'm not sure. I'll
take a look over the weekend.

Then again, getservbyname("0") taking time is wrong too :)

-d




More information about the openssh-unix-dev mailing list