DynamicWindow Patch

[Chris Rapier]

Markus Friedl wrote:
> On Wed, Jul 07, 2004 at 11:44:53PM -0400, Chris Rapier wrote:
> 
>>Michael Stevens wrote:
>>
>>>>>-     if (len > 0x100000)
>>>>>+     if (!buffer->unlimited && len > 0x100000)
>>>>>            fatal("buffer_append_space: len %u not supported", len);
>>>>
>>>>that's dangerous, is it really necessary? we could
>>>>crank the 0x100000.
>>>
>>>
>>>I'm not sure I see where the danger is coming from besides memory
>>>consumption when the  user locally sets a large window. The problem I
>>>see with that is now instead of unlimited, you can only go up to that
>>>static size. The unlimited flag is only set for the buffers in/out
>>>buffer on the channel.
>>
>>Something to keep in mind is that uping any static limit on the buffer 
>>size only pushes the problem off on to people down the line. The fact of 
> 
> 
> still, how does this matter if the tcp send and receive space are big enough?

How do you determine what is big enough so that 3 or 5 years from now we 
don't have to crank up that limit again?