Bug#252676: sshd failure

[Colin Watson]

On Sat, Jul 10, 2004 at 01:14:34PM +1000, Darren Tucker wrote:
> I was able to sometimes reproduce this on Debian by connecting to the 
> server PreferredAuthentications=keyboard-interactive then *immediately* 
> cancelling the authentication with ctrl-C.
> 
> After some digging I think I have found the cause: waitpid will return 
> zero if the process has not exited and none of the conditions listed 
> under "ERRORS" in the man page have been met.  Attached is a patch to 
> test for this too (which it should have done in the first place, sigh).
> 
> I have not been able to reproduce the problem with this patch.

That makes good sense to me, since in an strace here I'm seeing
waitpid() returning zero.

> (Interestingly, I was not able to reproduce it on Redhat by doing the 
> same thing.  I'm not sure why, but Debian is running on faster, dual CPU 
> box so it could be a timing issue.)

I can't reproduce it on Debian powerpc, which had been doing my head in;
I can well believe a timing issue.

I'm applying your patch and will upload shortly after a bit of testing.
Thanks!

-- 
Colin Watson                                  [cjwatson at flatline.org.uk]