Patch for login exchange timeout
Darren Tucker
dtucker at zip.com.au
Sat Mar 27 17:46:06 EST 2004
Damien Miller wrote:
> Mic Bowman wrote:
>
>>Here's a quick patch that adds a timeout (value set
>>from the connection timeout config parameter) for
>>identification exchange.
>
> I think the idea is ok, but IMO the implementation should do
> select+timeout rather than use signals.
> Also, maybe the timeout for the banner exchange should be
> ConnectionTimeout less the time actually used during the connect phase.
One possible approach would be to have the initial select() wait for
some data from the server (eg the banner), as per the attached patch.
--
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69
Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: openssh-connect-timeout.patch
Url: http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20040327/46431e62/attachment.ksh
More information about the openssh-unix-dev
mailing list