Call for release testing

[Jim Basney]

Jim Basney <jbasney at ncsa.uiuc.edu> wrote:
> Test results for openssh-SNAP-20050303.tar.gz:
> 
> Mac OS X 10.3.8 PowerPC G4 Darwin Kernel Version 7.8.0: FAIL
>   ./configure && make tests fails:
>     run test multiplex.sh ...
>     test connection multiplexing: envpass
>     test connection multiplexing: transfer
>     test connection multiplexing: status 0
>     test connection multiplexing: status 1
>     test connection multiplexing: status 4
>     test connection multiplexing: status 5
>     test connection multiplexing: status 44
>     Master running (pid=18137)
>     Exit request sent.
>     exit command failed
>     cat: /Users/jbasney/testing/openssh/regress/pidfile: No such file or directory
>     no sshd running
>     failed connection multiplexing
>     make[1]: *** [t-exec] Error 1
>     make: *** [tests] Error 2

Looks like '/bin/ps -p pid' for a non-existent pid exits with status 0
on Darwin.  Changing multiplex.sh to use 'kill -0 pid' fixes it.  With
that change, './configure && make tests' succeeds.

diff -Naur openssh.old/regress/multiplex.sh openssh.new/regress/multiplex.sh
--- openssh.old/regress/multiplex.sh	Mon Dec  6 06:12:15 2004
+++ openssh.new/regress/multiplex.sh	Thu Mar  3 11:42:31 2005
@@ -88,6 +88,6 @@
 # Wait for master to exit
 sleep 2
 
-ps -p $MASTER_PID >/dev/null && fail "exit command failed" 
+kill -0 $MASTER_PID >/dev/null 2>&1 && fail "exit command failed" 
 
 cleanup