OpenSSH_4.3p1 configure patch

[Darren Tucker]

On Tue, Feb 07, 2006 at 03:58:56PM -0800, Tim Rice wrote:
> On Tue, 7 Feb 2006, Corinna Vinschen wrote:
> 
> > On Feb  6 19:16, Corinna Vinschen wrote:
> > > I found another problem.  If I switch on privilege separation on
> > > Cygwin, I get two syslog messages per login, one from the privsep
> > > process and another one from the child sshd which handles the connection.
> > > 
> > > This is only a headsup so far, it's too late for today to debug this.
> > 
> > I found it.  If privilege separation is activated, monitor_child_preauth
> > calls auth_log.  If privilege separation is not used, userauth_finish
> > calls auth_log.  On systems lacking working descriptor passing, both
> > functions are called when privilege separation is on.  The only useful
> > way I found to get rid of one of the messages is not to print the
> > message from monitor_child_preauth, if DISABLE_FD_PASSING is set for
> > the target.  Patch below.  If somebody finds a way without adding another
> > #ifdef, I'd be very glad, though.
> 
> I can't duplicate this on another platform (SCO 507) that has
> DISABLE_FD_PASSING defined.

Do you have a /dev/log in the privsep chroot?  I suspect that Cygwin
uses some other method for passing its log messages which is why you're
seeing a difference.

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.