OpenSSH_4.3p1 configure patch

[Tim Rice]

On Wed, 8 Feb 2006, Darren Tucker wrote:

> On Tue, Feb 07, 2006 at 05:18:42PM -0800, Tim Rice wrote:
> > I don't like the monitor.c patch. The loggong will dissapear without
> > jumping through chroot logging hoops.
> > 
> > How about this instead?
> > Skip the monitor.c patch and use this.
> > 
> > --- auth2.c.old	2005-09-29 16:59:21.603708001 -0700
> > +++ auth2.c	2006-02-07 17:09:36.211231000 -0800
> > @@ -243,7 +243,9 @@
> >  #endif /* _UNICOS */
> >  
> >  	/* Log before sending the reply */
> > +#ifndef DISABLE_FD_PASSING
> >  	auth_log(authctxt, authenticated, method, " ssh2");
> > +#endif
> >  
> >  	if (authctxt->postponed)
> >  		return;
> 
> Won't that not log at all when DISABLE_FD_PASSING is defined and
> privsep=no?  Maybe:

Hmm, I hadn't considered privsep=no. After all, with DISABLE_FD_PASSING,
it's only preauth privsep.
> 
> #ifndef DISABLE_FD_PASSING
> 	if (!use_privsep)
> #endif

s/#ifndef/#ifdef/ Yes, that works.

> 		auth_log(authctxt, authenticated, method, " ssh2");
> 
> It still looks like there's got to be a nicer solution in there somewhere
> rather than something that's composed almost entirely of corner cases :-)

I'm happy to leave this one until after p2.

> 

-- 
Tim Rice				Multitalents	(707) 887-1469
tim at multitalents.net