session.c Was: Re: OpenSSH_4.3p1 configure patch

[Corinna Vinschen]

On Feb  7 15:29, Tim Rice wrote:
> On Tue, 7 Feb 2006, Corinna Vinschen wrote:
> > I'm not *quite* sure if I analyzed that correctly, but AFAICS, it should
> > have no effect on the situation solved by the patch from 2005/11/05:
> > 
> > - session_exit_message is a static function which is exclusively called
> >   by session_close_by_pid.
> > 
> > - In session_exit_message, following the setting of s->pid to 0 are only
> >   two calls, channel_register_cleanup and chan_write_failed.
> > 
> > - channel_register_cleanup only marks session_close_by_channel to be run
> >   for the channel on cleanup, but it does not run this function immediately,
> >   nor does it itself depend on the setting of s->pid.
> > 
> > - chan_write_failed does also not depend on the setting of s->pid.
> > 
> > - On return from session_exit_message to session_close_by_pid,
> >   session_pty_cleanup is called with correct s->pid setting.
> > 
> > - s->pid is set to 0.
> > 
> > - In a later cleanup, session_close_by_channel is called and s->pid has
> >   the expected value of 0.
> > 
> > Did I miss something?
> > 
> 
> It doesn't look like it to me. (and tests good here)
> I've commited your patch.

Thanks,
Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat