OpenSSH DNS resolution failure on IRIX 5.3: request to fix

[Darren Tucker]

On Mon, May 01, 2006 at 05:15:45PM -0700, Rick Jones wrote:
> I cannot speak to the specifics of this situation, but my past 
> experience with netperf DNS tests and trying to use _res directly was:
> 
> "There be dragons there!"
> 
> And IIRC I try not to do that in netperf4.  Different platforms may 
> handle _res differently depending on the app being threaded or not, etc. 
>    Some platforms may have resolver libraries based on particularly old 
> versions of BIND.
> 
> So, I would wonder the purpose to which _res was being accessed directly 
> and ask if perhaps there might be a different way to serve that purpose.

It's in the getrrsetbyname implementation, but afaict it's not accessed
directly elsewhere.  Maybe we can avoid the problem by just renaming
it to something else.  (This is a #define since sooner or later we will
need to sync the code again.)

Georg, does doing this instead still resolve the problem?

Index: openbsd-compat/getrrsetbyname.c
===================================================================
RCS file: /usr/local/src/security/openssh/cvs/openssh_cvs/openbsd-compat/getrrsetbyname.c,v
retrieving revision 1.17
diff -u -p -r1.17 getrrsetbyname.c
--- openbsd-compat/getrrsetbyname.c	12 Nov 2005 03:06:29 -0000	1.17
+++ openbsd-compat/getrrsetbyname.c	2 May 2006 00:51:49 -0000
@@ -60,6 +60,10 @@ extern int h_errno;
 # undef _THREAD_PRIVATE
 #endif
 #define _THREAD_PRIVATE(a,b,c) (c)
+
+/* to avoid conflicts where a platform already has _res */
+#define _res	_compat_res
+
 struct __res_state _res;
 
 /* Necessary functions and macros */

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.