xmalloc symbol in libssh

[Jeremie Le Hen]

Hi list,

(Please Cc: me in your replies because I'm not subscribed to this list.)

While trying to build lukemftpd staticaly on FreeBSD, I got a link-time
error.  Libssh.a indeed provides the "xmalloc" symbol (I suppose there
are more).  I wonder if this is whether intentional or not.  It is a
very common function name, and I think it would be worth renaming
it to something like ssh_xmalloc() or openssh_xmalloc().

I can provide a patch on request.

%%%
% cc -O2 -fno-strict-aliasing -pipe -march=pentium-m -include nbsd2fbsd.h -I/usr/src/libexec/lukemftpd -I/usr/src/libexec/lukemftpd/../../contrib/lukemftpd -I/usr/src/libexec/lukemftpd/../../contrib/lukemftpd/src -I/usr/src/libexec/lukemftpd/../../lib/libc/stdtime -I/usr/src/libexec/lukemftpd/../../bin/ls -DUSE_OPIE -DLOGIN_CAP -DUSE_PAM -fstack-protector   -static -o lukemftpd cmds.o conf.o ftpd.o ftpcmd.o popen.o strsuftoll.o ls-unmain.o cmp.o print.o util.o -lcrypt -lutil -lm -lopie -lmd -lpam -lkrb5 -lasn1 -lcrypto -lcrypt -lroken -lcom_err -lradius -ltacplus -lcrypt  -lutil -lopie -lmd -lssh -lcrypto -lcrypt -lypclnt
% /usr/obj/usr/src/tmp/usr/lib/libssh.a(xmalloc.o)(.text+0xd0): In function `xstrdup':
% : multiple definition of `xstrdup'
% ftpd.o(.text+0x1460): first defined here
% /usr/obj/usr/src/tmp/usr/bin/ld: Warning: size of symbol `xstrdup' changed from 44 in ftpd.o to 70 in /usr/obj/usr/src/tmp/usr/lib/libssh.a(xmalloc.o)
%%%

Regards,
-- 
Jeremie Le Hen
< jeremie at le-hen dot org >< ttz at chchile dot org >