[PATCH 10/12 bugfix: openssh-4.3p2: memory leak

Balaraman, Srinath srinath_balaraman at mentor.com
Wed May 17 00:13:02 EST 2006


Why is it that the "local_user" is being freed only in case of SSH1 and
not in case of SSH2?


-----Original Message-----
From: openssh-unix-dev-bounces+srinath_balaraman=mentor.com at mindrot.org
[mailto:openssh-unix-dev-bounces+srinath_balaraman=mentor.com at mindrot.or
g] On Behalf Of Kylene Jo Hall
Sent: Monday, May 15, 2006 3:19 PM
To: openssh-devel
Subject: [PATCH 10/12 bugfix: openssh-4.3p2: memory leak

The variable local_user was allocated by xstrdup and is not freed or
pointed to in this branch.  This patch adds the xfree.  This entire set
of patches passed the regression tests on my system. Bug found by
Signed-off-by: Kylene Hall <kjhall at us.ibm.com>
sshconnect.c |    1 +
1 files changed, 1 insertion(+)

diff -uprN openssh-4.3p2/sshconnect.c openssh-4.3p2-kylie/sshconnect.c
--- openssh-4.3p2/sshconnect.c	2005-12-13 02:29:03.000000000 -0600
+++ openssh-4.3p2-kylie/sshconnect.c	2006-05-04 10:07:57.000000000
@@ -937,6 +937,7 @@ ssh_login(Sensitive *sensitive, const ch
 	} else {
 		ssh_kex(host, hostaddr);
 		ssh_userauth1(local_user, server_user, host, sensitive);
+		xfree(local_user);

openssh-unix-dev mailing list
openssh-unix-dev at mindrot.org

More information about the openssh-unix-dev mailing list