Testing for the 4.4p1 release

[Darren Tucker]

On Wed, Aug 30, 2006 at 11:41:53PM +1000, Damien Miller wrote:
> The 4.4p1 release is approaching now, so we are now asking people to 
> actively test snapshots or CVS and report back to the mailing list.

It seems that *really* old systems that don't declare writev will not
build because the function can't be passed as an argument to atomiciov.

The patch below fixes this, and while I don't think it would affect any
other platforms I'm not sure it's worth putting in at this point.

Index: configure.ac
===================================================================
RCS file: /usr/local/src/security/openssh/cvs/openssh_cvs/configure.ac,v
retrieving revision 1.357
diff -u -p -r1.357 configure.ac
--- configure.ac	1 Sep 2006 10:29:11 -0000	1.357
+++ configure.ac	3 Sep 2006 08:41:34 -0000
@@ -1328,6 +1328,11 @@ AC_CHECK_DECLS(O_NONBLOCK, , ,
 #endif
 	])
 
+AC_CHECK_DECLS(writev, , , [
+#include <sys/types.h>
+#include <sys/uio.h>
+	])
+
 AC_CHECK_FUNCS(setresuid, [
 	dnl Some platorms have setresuid that isn't implemented, test for this
 	AC_MSG_CHECKING(if setresuid seems to work)
Index: openbsd-compat/openbsd-compat.h
===================================================================
RCS file: /usr/local/src/security/openssh/cvs/openssh_cvs/openbsd-compat/openbsd-compat.h,v
retrieving revision 1.41
diff -u -p -r1.41 openbsd-compat.h
--- openbsd-compat/openbsd-compat.h	30 Aug 2006 17:24:42 -0000	1.41
+++ openbsd-compat/openbsd-compat.h	2 Sep 2006 13:18:16 -0000
@@ -131,6 +131,11 @@ int getgrouplist(const char *, gid_t, gi
 int BSDgetopt(int argc, char * const *argv, const char *opts);
 #endif
 
+#if defined(HAVE_DECL_WRITEV) && HAVE_DECL_WRITEV == 0
+# include <sys/types.h>
+# include <sys/uio.h>
+int writev(int, struct iovec *, int);
+#endif
 
 /* Home grown routines */
 #include "bsd-misc.h"

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.