Testing for the 4.4p1 release

[Darren Tucker]

On Thu, Aug 31, 2006 at 08:50:04AM +0300, Pekka Savola wrote:
> On Wed, 30 Aug 2006, Damien Miller wrote:
> > Running the regression tests supplied with Portable does not require
> > installation, just run:
> >
> > $ ./configure && make tests
> >
> > Testing on suitable non-production systems is also appreciated. Please send
> > reports of success or failure to openssh-unix-dev at mindrot.org, including
> > details of your platform, compiler and configure options.

Thanks for testing and sorry it took so long to get back to you.

> On RHL73 with gcc 2.96, 'make tests' doesn't finish and appears to get 
> stuck (strace shows the process is in wait()).  There were a number of 
> compilation warnings.  The ones coming from ciphers and macs appear to 
> be old, but these are new and at least implicit decls should be easily 
> fixable:
> 
> warning: __nonnull__' attribute directive ignored (50+ times)

We could do something like the patch below.

> uidswap.c: In function Permanently_drop_suid':
> uidswap.c:142: warning: implicit declaration of function Setresuid'
> uidswap.c: In function Permanently_set_uid':
> uidswap.c:224: warning: implicit declaration of function Setresgid'

Last time I looked, setresuid and setresgid were not defined in any system
header on old Linuxes.

> md5crypt.c: In function To64':
> md5crypt.c:31: warning: implicit declaration of function Memset'
> md5crypt.c: In function         s_md5_salt':
> md5crypt.c:43: warning: implicit declaration of function Strncmp'
> md5crypt.c:43: warning: implicit declaration of function Strlen'
> md5crypt.c: In function Md5_crypt':
> md5crypt.c:73: warning: implicit declaration of function Memcpy'

These have been fixed by including string.h.

[...]
> from 127.0.0.1 port 44319 (t4 r26 i0/0 o0/0 fd 27/27 cfd -1)
> [[ almost 10 minute timeout ]]
> ssh_exchange_identification: Connection closed by remote host
> cmp: EOF on /home/pekkas/op/openssh/regress/ls.copy
> corrupted copy of /bin/ls
> bind: Address already in use
> [[ about 5 minute timeout ]]

Now this I'm not sure about.

Index: defines.h
===================================================================
RCS file: /usr/local/src/security/openssh/cvs/openssh/defines.h,v
retrieving revision 1.137
diff -u -p -r1.137 defines.h
--- defines.h	18 Aug 2006 22:38:24 -0000	1.137
+++ defines.h	10 Sep 2006 05:04:31 -0000
@@ -449,6 +449,10 @@ struct winsize {
 # define __bounded__(x, y, z)
 #endif
 
+#ifndef __nonnull__
+# define __nonnull__
+#endif
+
 /* *-*-nto-qnx doesn't define this macro in the system headers */
 #ifdef MISSING_HOWMANY
 # define howmany(x,y)	(((x)+((y)-1))/(y))

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.