bug(let): openssh v4.3p2 'ok' out-of-box; 'configure' does not survive 'autoreconf'

[Darren Tucker]

On Thu, Sep 21, 2006 at 06:56:59AM -0700, OpenMacNews wrote:
> building OPENSSH v4.3p2 on OSX 10.4.7, all's fine (config, nake, 
> install, exec) out-of-the-box. so, to be clear, this is NOT a blocker, 
> by any stretch ...
> 
> that said, however ...
> 
> if, instead of a don't-monkey-with-it build, prior to ./configure, i:
> 
> 	autoreconf -i -f
[...]
> stems from, in 'configure.ac':
> 
> 	1406	dnl see whether mkstemp() requires XXXXXX
> 	1407	if test "x$ac_cv_func_mkdtemp" = "xyes" ; then
> 	1408	AC_MSG_CHECKING([for (overly) strict mkstemp])
> 	1409	AC_RUN_IFELSE(
> 	1410		[AC_LANG_SOURCE([[
> 	1411	#include <stdlib.h>
> 	1412	main() { char template[]="conftest.mkstemp-test";
> 	1413	if (mkstemp(template) == -1)
> 	1414		exit(1);
> 	1415	unlink(template); exit(0);
> 	1416	}
> - ->	1417		]])],
> 	1418		[
> 	1419			AC_MSG_RESULT(no)
> 	1420		],

Thanks, I believe this was caused by a missing bracket elsewhere that has
already been fixed (configure.ac rev 1.343).  Autoconf 2.59 didn't care
but 2.60 does.

Index: configure.ac
===================================================================
RCS file: /usr/local/src/security/openssh/cvs/openssh/configure.ac,v
retrieving revision 1.342
retrieving revision 1.343
diff -u -p -r1.342 -r1.343
--- configure.ac	24 Jun 2006 02:10:07 -0000	1.342
+++ configure.ac	27 Jun 2006 01:20:29 -0000	1.343
@@ -1623,6 +1623,7 @@ main(void)
 			AC_MSG_RESULT(no)
 			AC_DEFINE(BROKEN_GETADDRINFO)
 		],
+		[
 			AC_MSG_RESULT(cross-compiling, assuming no)
 		]
 	)

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.