ExitOnForwardFailure and Protocol 2.0

[William Ahern]

On Wed, Sep 27, 2006 at 10:45:54AM +1000, Darren Tucker wrote:
> William Ahern wrote:
> >I'm merging my "streamlocal" unix domain socket forwarding patch into 4.4p1
> >(or rather 20060926 SNAP) and I gather that the ExitOnForwardFailure
> >capability only works for protocol 1.0.
> >
> >Am I misreading things? I was really looking forward to that feature.
> 
> I think so, I use ExitOnForwardFailure with protocol 2 all the time.
> 
> $ ssh -2 -o exitonforwardfailure=yes -R 22:127.0.0.1:22 localhost
> Error: remote port forwarding failed for listen port 22
> $ ssh -V
> OpenSSH_4.4p1, OpenSSL 0.9.7f 22 Mar 2005
> 
> Can you give an example of it not working?
> 

Interesting. Then line 2543 of channels.c is confusing me:

	packet_start(SSH2_MSG_GLOBAL_REQUEST);
	packet_put_cstring("tcpip-forward");
	packet_put_char(1);			/* boolean: want reply */
	packet_put_cstring(address_to_bind);
	packet_put_int(listen_port);
	packet_send();
	packet_write_wait();
	/* Assume that server accepts the request */
	success = 1;