RFE: idle timeout/auto-daemonize combo

[Wout Mertens]

On Jul 5, 2007, at 5:33 PM, David Woodhouse wrote:

> On Thu, 2007-07-05 at 09:13 +1000, Damien Miller wrote:
>> Please file bugs for these on https://bugzilla.mindrot.org/ so
>> I don't forget about them again.
>
> https://bugzilla.mindrot.org/show_bug.cgi?id=1328 - multiple $DISPLAY
> https://bugzilla.mindrot.org/show_bug.cgi?id=1329 - stale sockets
> https://bugzilla.mindrot.org/show_bug.cgi?id=1330 - ControlPersist
>
> Sorry, I haven't updated the patches and made sure they build and work
> with the current CVS tree. And my multi-display patch contains some
> other fixes which I think came from you in the first place so I  
> haven't
> tried to explain them in detail. But it's basically there.

Well I patched a 4.6p1 without rejects and it compiled fine. One  
thing I notice is that it enables controlpersist by default. You  
don't initialize control_persist in readconf.c, is that not necessary?

Another thing I noticed is that I can't specify the controlpersist  
value on the command line, it probably only parses the one in config  
files. I'm not totally up to speed with the code yet, so I don't know  
why that is.

> We need to have the argument about multiple agent support again, but I
> need to win it this time.

I've been trying to think of a use case for this... Would a  
workaround not be to have a master per $DISPLAY?

> And we need to sort out the escape handling --
> stuff like ~. doesn't work for a ControlClient. That's filed as #1331.

Good point!

> At some point when I have a little more time, I'll adjust my
> ControlPersist patch to close stdin/stdout/stderr. I keep finding that
> cvs waits for ssh to finish, and when I log out of ssh sessions I've
> started a dæmon from, they hang too.

Why don't you replace the daemonizing bit with a call to daemon(0,0)?  
I did that and it seems to work just fine, and it behaves better  
cross-platform to boot.

Right now I'm experimenting, trying to get the IdleTimeout patch for  
sshd ported to the latest versions and getting it to do the same  
thing with ssh. Together with ControlPersist that will be an awesome  
combo for scripting.

Cheers,

Wout.