Call for release testing.

[Corinna Vinschen]

On Mar  1 23:54, Darren Tucker wrote:
> Hi All.
> 
> We are planning on doing one of our regular OpenSSH releases (4.6/4.6p1) 
> some time next week.  This is a mostly a bugfix release, but there is 
> one new feature:
> [...]
> Testing on suitable non-production systems is also appreciated.
> Please send reports of success or failure to
> openssh-unix-dev at mindrot.org.

Current CVS builds and runs fine on Cygwin.  However, the testsuite
didn't work out of the box.  After some time I figured out that this is
related to the lineendings in the pidfile (CRLF instead of just LF).  It
occured to me that OpenSSH on Cygwin is still built so that it uses
textmode instead of binary mode when writing files.  However, the right
way to do this is to read files in textmode (which allows CRLF as well
as LF lineendings) and to write in binary mode, except the path to the
output file is mounted in textmode(*).

So, I hope it's still not too late to get the below patch in, before
4.6p1 is released.  With this patch, the testsuite runs fine OOTB as well.


Thanks in advance,
Corinna


Index: configure.ac
===================================================================
RCS file: /cvs/openssh/configure.ac,v
retrieving revision 1.370
diff -p -u -r1.370 configure.ac
--- configure.ac	6 Oct 2006 23:07:21 -0000	1.370
+++ configure.ac	1 Mar 2007 18:38:52 -0000
@@ -360,7 +360,7 @@ int main(void) { exit(0); }
 	;;
 *-*-cygwin*)
 	check_for_libcrypt_later=1
-	LIBS="$LIBS /usr/lib/textmode.o"
+	LIBS="$LIBS /usr/lib/textreadmode.o"
 	AC_DEFINE(HAVE_CYGWIN, 1, [Define if you are on Cygwin])
 	AC_DEFINE(USE_PIPES, 1, [Use PIPES instead of a socketpair()])
 	AC_DEFINE(DISABLE_SHADOW, 1,


(*) I really hate having to consider this Windowism.

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat