4.7p1 password auth broken on SCO OSR6

[Tim Rice]

On Fri, 14 Sep 2007, Roger Cornelius wrote:

RC On 09/13/2007 15:18, Roger Cornelius wrote:
RC > On 09/10/2007 16:14, Tim Rice wrote:
RC > > On Mon, 10 Sep 2007, Roger Cornelius wrote:
RC > > 
RC > > > openssh 4.7p1
RC > > > SCO OSR6
RC > > > 
RC > > > Password authentication is non-functional.  This seems dependent on
RC > > > USE_LIBIAF which further depends on HAVE_LIBIAF (in defines.h), but
RC > > > there is no longer any code in configure to define the latter.  Building
RC > > 
RC > > This patch will solve the missing HAVE_LIBIAF
RC > > ------------
RC > > --- configure.ac.old	2007-08-15 09:16:29.007892000 -0700
RC > > +++ configure.ac	2007-09-10 15:54:26.072835157 -0700
RC > > @@ -2004,7 +2004,10 @@
RC > >  saved_LIBS="$LIBS"
RC > >  AC_CHECK_LIB(iaf, ia_openinfo, [
RC > >  	LIBS="$LIBS -liaf"
RC > > -	AC_CHECK_FUNCS(set_id, [SSHDLIBS="$SSHDLIBS -liaf"])
RC > > +	AC_CHECK_FUNCS(set_id, [SSHDLIBS="$SSHDLIBS -liaf"
RC > > +				AC_DEFINE(HAVE_LIBIAF, 1,
RC > > +        		[Define if system has libiaf that supports set_id])
RC > > +				])
RC > >  ])
RC > >  LIBS="$saved_LIBS"
RC > >  
RC > > ------------
RC > > 
RC > > > with HAVE_LIBIAF defined enables password authentication, but only for
RC > > > non-long (<9 char) passwords, even though UNIXWARE_LONG_PASSWORDS seems
RC > > > to be defined.  I haven't had time yet to investigate further.

I tracked down the problem. CUSTOM_SYS_AUTH_PASSWD was not defined so
the UNIXWARE_LONG_PASSWORDS bit were never used.

Please backout your changes to configure.ac (leave my patch in) and
openbsd-compat/xcrypt.c and try this patch.

Thanks.

----------------------------
--- defines.h.old	2007-08-15 09:16:29.167892001 -0700
+++ defines.h	2007-09-15 19:17:15.331975020 -0700
@@ -694,9 +694,11 @@
 # define CUSTOM_SYS_AUTH_PASSWD 1
 #endif
 
+#if defined(HAVE_LIBIAF) && defined(HAVE_SET_ID)
+# define CUSTOM_SYS_AUTH_PASSWD 1
+#endif
 #if defined(HAVE_LIBIAF) && defined(HAVE_SET_ID) && !defined(BROKEN_LIBIAF)
 # define USE_LIBIAF
-# define CUSTOM_SYS_AUTH_PASSWD 1
 #endif
 
 /* HP-UX 11.11 */
----------------------------

-- 
Tim Rice				Multitalents	(707) 887-1469
tim at multitalents.net