[PATCH] Build problem in current portable CVS

[Corinna Vinschen]

On Feb 25 20:16, Darren Tucker wrote:
> On Mon, Feb 18, 2008 at 12:55:54PM +0100, Corinna Vinschen wrote:
> > Hi,
> > 
> > I just tried to build the latest portable code from CVS on Cygwin.
> > I stumbled over a problem with the definitions of gai_strerror and
> > ssh_gai_strerror.
> > 
> > On systems not having gai_strerror, the fake-rfc2553.c file defines
> > its own version of gai_strerror, and fake-rfc2553.h additionally has
> > this definition of gai_strerror:
> > 
> > #define gai_strerror(a)         (ssh_gai_strerror(a))
> 
> What moron put that there?  oh wait, it was me :-)
> 
> Actually it's been there for a while and there's a reason for it: it
> prevents name clash problems with Heimdal's libroken.
> 
> Unfortunately, when I added that helper function to the OpenBSD version,
> I picked the same name, thus the problem.
> 
> Just removing it will reintroduce the libroken problem, but changing the
> name should sort both out.  I'm about to commit the following which should
> do the job.

Thanks.  Builds fine on Cygwin again.


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat