Testing wanted: OpenSSH 4.8

[Peter Stuge]

On Thu, Mar 13, 2008 at 03:41:37PM +1100, Damien Miller wrote:
> > > FYI these tests were broken unless you happened to have plink and
> > > puttygen installed in /usr/local/bin. I'm just about to commit a
> > > fix

> > /home/ossh/openssh/regress/test-exec.sh: line 297: puttygen: command not found
> > /home/ossh/openssh/regress/test-exec.sh: line 298: puttygen: command not found
> 
> Is puttygen in your $PATH? or do you not have it installed at all?

Not installed at all.


> Either way, please try this diff:
> 
> Index: regress/test-exec.sh
> ===================================================================
> RCS file: /var/cvs/openssh/regress/test-exec.sh,v
> retrieving revision 1.32
> diff -u -p -r1.32 test-exec.sh
> --- regress/test-exec.sh	13 Mar 2008 01:41:31 -0000	1.32
> +++ regress/test-exec.sh	13 Mar 2008 04:40:32 -0000
> @@ -104,14 +104,14 @@ if [ "x$TEST_SSH_PLINK" != "x" ]; then
>  	# Find real binary, if it exists
>  	case "${TEST_SSH_PLINK}" in
>  	/*) PLINK="${TEST_SSH_PLINK}" ;;
> -	*) PLINK=`which ${TEST_SSH_PLINK}` ;;
> +	*) PLINK=`which ${TEST_SSH_PLINK} 2>/dev/null` ;;

This helps remove the error message from which.


In addition I need the following patch to fix the errors I reported:

Index: regress/test-exec.sh
===================================================================
RCS file: /cvs/openssh/regress/test-exec.sh,v
retrieving revision 1.32
diff -u -r1.32 test-exec.sh
--- regress/test-exec.sh	13 Mar 2008 01:41:31 -0000	1.32
+++ regress/test-exec.sh	13 Mar 2008 17:31:28 -0000
@@ -289,7 +289,7 @@
 
 # If PuTTY is present, prepare keys and configuration
 REGRESS_INTEROP_PUTTY=no
-if test -x $PUTTYGEN -a -x $PLINK ; then
+if test -x "${PUTTYGEN}" -a -x "${PLINK}" ; then
 	mkdir -p ${OBJ}/.putty
 
 	# Add a PuTTY key to authorized_keys

Along with Corinna's sftp-cmds.sh patch all tests now pass on i686
Gentoo Linux with glibc-2.6.1.


//Peter