Memory leak in do_ssh2_kex()

[miguel.sanders at arcelormittal.com]

It didn't work.
You can the find the patch (memleak.patch) here aswell:

ftp://6tvLa11g:ZB0b073qxZ@193.121.250.205 


Met vriendelijke groet
Best regards
Bien à vous

Miguel SANDERS
ArcelorMittal Gent

UNIX Systems & Storage
IT Supply Western Europe | John Kennedylaan 51
B-9042 Gent

T +32 9 347 3538 | F +32 9 347 4901 | M +32478 805 023
E miguel.sanders at arcelormittal.com
www.arcelormittal.com/gent

-----Oorspronkelijk bericht-----
Van: openssh-unix-dev-bounces+miguel.sanders=arcelormittal.com at mindrot.org [mailto:openssh-unix-dev-bounces+miguel.sanders=arcelormittal.com at mindrot.org] Namens miguel.sanders at arcelormittal.com
Verzonden: dinsdag 31 maart 2009 21:19
Aan: openssh-unix-dev at mindrot.org
Onderwerp: RE: Memory leak in do_ssh2_kex()

No problem :)
I added the patch as an attachment.
Hopefully it passes this time...



Met vriendelijke groet
Best regards
Bien à vous

Miguel SANDERS
ArcelorMittal Gent

UNIX Systems & Storage
IT Supply Western Europe | John Kennedylaan 51
B-9042 Gent

T +32 9 347 3538 | F +32 9 347 4901 | M +32478 805 023 E miguel.sanders at arcelormittal.com www.arcelormittal.com/gent

-----Oorspronkelijk bericht-----
Van: openssh-unix-dev-bounces+miguel.sanders=arcelormittal.com at mindrot.org [mailto:openssh-unix-dev-bounces+miguel.sanders=arcelormittal.com at mindrot.org] Namens Peter Stuge
Verzonden: dinsdag 31 maart 2009 20:49
Aan: openssh-unix-dev at mindrot.org
Onderwerp: Re: Memory leak in do_ssh2_kex()

miguel.sanders at arcelormittal.com wrote:
> Should I make a patch for this?

I think that sounds good.


> Also, since my previous patch was not according to the your standards, 
> how many lines of context do you normally want in a patch file?

It's not so much about the amount of context. The point is that diff defaults to "context diff" which is more difficult for most to read than "unified diff" which requires diff to be run with -u or e.g.
-U 2.

I think I mixed up u and U in the email, sorry for that confusion. :\


//Peter
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev at mindrot.org
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev

****
This message and any attachment are confidential, intended solely for the use of the individual or entity to whom it is addressed and may be protected by professional secrecy or intellectual property rights. 
If you have received it by mistake, or are not the named recipient(s), please immediately notify the sender and delete the message. You are hereby notified that any unauthorized use, copying or dissemination of any or all information contained in this message is prohibited. 
Arcelormittal shall not be liable for the message if altered, falsified, or in case of error in the recipient. 
This message does not constitute any right or commitment for ArcelorMittal except when expressly agreed otherwise in writing in a separate agreement.  
****  


**** 
This message and any attachment are confidential, intended solely for the use of the individual or entity to whom it is addressed and may be protected by professional secrecy or intellectual property rights. 
If you have received it by mistake, or are not the named recipient(s), please immediately notify the sender and delete the message. You are hereby notified that any unauthorized use, copying or dissemination of any or all information contained in this message is prohibited. 
Arcelormittal shall not be liable for the message if altered, falsified, or in case of error in the recipient. 
This message does not constitute any right or commitment for ArcelorMittal except when expressly agreed otherwise in writing in a separate agreement.  
****