sftp SSH2_FXP_SYMLINK argument order

[Alexander Larsson]

On Thu, 2009-02-26 at 23:26 +1100, Damien Miller wrote:
> On Thu, 26 Feb 2009, Alexander Larsson wrote:
> 
> > Reading 6.10 Dealing with Symbolic links in
> > http://www.openssh.org/txt/draft-ietf-secsh-filexfer-02.txt it seems to
> > say that the first argument ('linkpath') specifies the name of the
> > symlink file to create. ("linkpath' specifies the path name of the
> > symlink to be created").
> > 
> > However, sftp-server.c:process_symlink() seems to reverse this.
> > I.E. the first argument ('oldpath') is passed as the first argument to
> > symlink(). But for symlink() the second argument specifies the new file
> > to create.
> > 
> > I guess its kinda hard to fix this now, as a lot of deployments may rely
> > on the old behaviour. But maybe it would be nice to document this
> > somewhere?
> 
> You mean like
> 
> http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/PROTOCOL?rev=1.12;content-type=text%2Fx-cvsweb-markup;ln=1#l162

Excellent. Didn't know about this file.