[PATCH] "Include" option for ssh configs

[Gavin Beatty]

On Tue, Mar 24, 2009 at 5:57 PM, Jefferson Ogata
<Jefferson.Ogata at noaa.gov> wrote:
> On 2009-03-24 17:39, Gavin Beatty wrote:
>> PS: I don't understand the significance of NFS in your example. The
>> probability of ~/.ssh/config also being on said NFS mount is near one.
>
> It's nowhere near one.
>
> Solaris traditionally uses /export/home for local home directories, and
> /home is an NFS mount point. IRIX traditionally uses /usr/people for
> home directories. Please don't make Linux-centric assumptions about
> people's filesystem layouts in a portable remote shell program.

I wasn't intentionally wearing my Linux hat. Wrong is wrong though - apologies.
SUSv3 is open again.

I've removed the offending fallback and re-attached the patch.

Also fixed is a bug where long usernames in ~someloooooongusername/config would
truncate after L_cuserid chars, expanding to someloooo, say, whose passwd entry
would be checked. Also, the expanded string would not be of the form
$HOME/config for someloooo's home (not that that is the biggest problem). Big
Bug. Now, username length is memory-bound.

I take it that FOO_r functions are similarly not portable enough. Attached is
another patch which incorporates the above changes _and_ uses the non-reentrant
versions.

Are there any other issues?

On Tue, Mar 24, 2009 at 6:09 PM, Rob Banz <rob at nofocus.org> wrote:
> [snip] heck, I've never used /export/home as a home directory on
> Solaris ;)

+1 :S

-- 
Gavin Beatty

SEMPER UBI SUB UBI
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openssh-include-no-home-fallback.patch
Type: text/x-patch
Size: 5743 bytes
Desc: not available
Url : http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20090325/e48c9760/attachment-0002.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openssh-include-no-home-fallback-no-reentrancy.patch
Type: text/x-patch
Size: 5293 bytes
Desc: not available
Url : http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20090325/e48c9760/attachment-0003.bin