Call for testing: OpenSSH-5.6

[Darren Tucker]

On Sat, Aug 14, 2010 at 09:11:30PM +0200, Tom Christensen wrote:
> Damien Miller wrote:
> >Hi,
> >
> >OpenSSH 5.6 is almost ready for release, so we would appreciate testing
> >on as many platforms and systems as possible. This is a moderately large
> >release, with a number of new features and bug fixes.
> >
> >Snapshot releases for portable OpenSSH are available from
> >http://www.mindrot.org/openssh_snap/
> >
> >Running the regression tests supplied with Portable OpenSSH does not
> >require installation and is a simply:
> >
> >$ ./configure && make tests
> >
> I tried building openssh-SNAP-20100815 on IRIX 5.3 but it fails
> because this platform lacks strptime:

It's only used when generating time-based certificates, so the quick and
dirty hack is to just disable that on platforms that don't have
strptime.  (I looked at pulling in support from openbsd but it's a
tangled web of locale stuff).

Please try this patch (you will need to run "autoreconf" to rebuild
configure).

Index: configure.ac
===================================================================
RCS file: /usr/local/src/security/openssh/cvs/openssh/configure.ac,v
retrieving revision 1.450
diff -u -p -r1.450 configure.ac
--- configure.ac	23 Apr 2010 01:12:06 -0000	1.450
+++ configure.ac	15 Aug 2010 01:45:50 -0000
@@ -1427,6 +1427,7 @@ AC_CHECK_FUNCS( \
 	strlcpy \
 	strmode \
 	strnvis \
+	strptime \
 	strtonum \
 	strtoll \
 	strtoul \
Index: ssh-keygen.c
===================================================================
RCS file: /usr/local/src/security/openssh/cvs/openssh/ssh-keygen.c,v
retrieving revision 1.211
diff -u -p -r1.211 ssh-keygen.c
--- ssh-keygen.c	5 Aug 2010 03:05:32 -0000	1.211
+++ ssh-keygen.c	15 Aug 2010 01:47:08 -0000
@@ -1480,6 +1480,7 @@ parse_relative_time(const char *s, time_
 static u_int64_t
 parse_absolute_time(const char *s)
 {
+#ifdef HAVE_STRPTIME
 	struct tm tm;
 	time_t tt;
 	char buf[32], *fmt;
@@ -1509,6 +1510,9 @@ parse_absolute_time(const char *s)
 	if ((tt = mktime(&tm)) < 0)
 		fatal("Certificate time %s cannot be represented", s);
 	return (u_int64_t)tt;
+#else
+	fatal("Time-based certificates not supported on this platform");
+#endif
 }
 
 static void

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.