Call for testing: OpenSSH-5.4

[Colin Watson]

In article <alpine.BSO.2.00.1002271127510.1818 at fuyu.mindrot.org>, Damien
Miller wrote:
>Running the regression tests supplied with Portable OpenSSH does not
>require installation and is a simply:
>
>$ ./configure && make tests

I built this from CVS on Ubuntu 10.04 (in development).  I used
configure options which closely approximate those we use for the Debian
package, omitting a couple that go along with Debian patches:

  ./configure --build=i486-linux-gnu --prefix=/usr --sysconfdir=/etc/ssh --libexecdir=/usr/lib/openssh --mandir=/usr/share/man --disable-strip --with-mantype=doc --with-4in6 --with-privsep-path=/var/run/sshd --without-rand-helper --with-tcp-wrappers --with-pam --with-libedit --with-ssl-engine --with-selinux --with-xauth=/usr/bin/X11/xauth --with-default-path=/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/usr/games --with-superuser-path=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/bin/X11 --with-cflags='-O2 -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -DLOGIN_PROGRAM=\"/bin/login\" -DLOGIN_NO_ENDOPT' --with-ldflags='-Wl,--as-needed -fPIE -pie -Wl,-z,relro -Wl,-z,now'

There were a few compiler warnings most of which I don't think are
particularly new, although I don't recognise the one in
openssl-compat.c.  I don't know if you care about all of these but I'll
list them for completeness.

All regression tests passed.  I haven't done serious testing beyond
that, although I confirmed that sftp's tab-completion seemed to be
working.


gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wno-pointer-sign -Wformat-security -fno-builtin-memset -fstack-protector-all -O2 -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -DLOGIN_PROGRAM=\"/bin/login\" -DLOGIN_NO_ENDOPT  -I. -I.. -I. -I./..  -DHAVE_CONFIG_H -c openssl-compat.c
openssl-compat.c: In function ‘ssh_SSLeay_add_all_algorithms’:
openssl-compat.c:70: warning: implicit declaration of function ‘OPENSSL_config’

gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wno-pointer-sign -Wformat-security -fno-builtin-memset -fstack-protector-all -O2 -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -DLOGIN_PROGRAM=\"/bin/login\" -DLOGIN_NO_ENDOPT  -I. -I.. -I. -I./..  -DHAVE_CONFIG_H -c bindresvport.c
bindresvport.c: In function ‘bindresvport_sa’:
bindresvport.c:71: warning: dereferencing pointer ‘sa’ does break strict-aliasing rules
bindresvport.c:66: note: initialized from here

gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wno-pointer-sign -Wformat-security -fno-builtin-memset -fstack-protector-all -O2 -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -DLOGIN_PROGRAM=\"/bin/login\" -DLOGIN_NO_ENDOPT  -I. -I.. -I. -I./..  -DHAVE_CONFIG_H -c readpassphrase.c
readpassphrase.c: In function ‘readpassphrase’:
readpassphrase.c:127: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result
readpassphrase.c:146: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result

gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wno-pointer-sign -Wformat-security -fno-builtin-memset -fstack-protector-all -O2 -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -DLOGIN_PROGRAM=\"/bin/login\" -DLOGIN_NO_ENDOPT  -I. -I.  -DSSHDIR=\"/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/lib/openssh/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/lib/openssh/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/lib/openssh/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/lib/openssh/ssh-pkcs11-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/run/sshd\" -DSSH_RAND_HELPER=\"/usr/lib/openssh/ssh-rand-helper\" -DHAVE_CONFIG_H -c channels.c
channels.c: In function ‘channel_decode_socks5’:
channels.c:1235: warning: dereferencing type-punned pointer will break strict-aliasing rules

gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wno-pointer-sign -Wformat-security -fno-builtin-memset -fstack-protector-all -O2 -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -DLOGIN_PROGRAM=\"/bin/login\" -DLOGIN_NO_ENDOPT  -I. -I.  -DSSHDIR=\"/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/lib/openssh/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/lib/openssh/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/lib/openssh/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/lib/openssh/ssh-pkcs11-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/run/sshd\" -DSSH_RAND_HELPER=\"/usr/lib/openssh/ssh-rand-helper\" -DHAVE_CONFIG_H -c log.c
log.c: In function ‘do_log’:
log.c:388: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result

gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wno-pointer-sign -Wformat-security -fno-builtin-memset -fstack-protector-all -O2 -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -DLOGIN_PROGRAM=\"/bin/login\" -DLOGIN_NO_ENDOPT  -I. -I.  -DSSHDIR=\"/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/lib/openssh/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/lib/openssh/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/lib/openssh/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/lib/openssh/ssh-pkcs11-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/run/sshd\" -DSSH_RAND_HELPER=\"/usr/lib/openssh/ssh-rand-helper\" -DHAVE_CONFIG_H -c packet.c
packet.c: In function ‘packet_connection_is_ipv4’:
packet.c:441: warning: dereferencing pointer ‘to.48’ does break strict-aliasing rules
packet.c:441: note: initialized from here
packet.c:441: warning: dereferencing pointer ‘to.48’ does break strict-aliasing rules
packet.c:441: note: initialized from here
packet.c:441: warning: dereferencing pointer ‘to.48’ does break strict-aliasing rules
packet.c:441: note: initialized from here

gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wno-pointer-sign -Wformat-security -fno-builtin-memset -fstack-protector-all -O2 -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -DLOGIN_PROGRAM=\"/bin/login\" -DLOGIN_NO_ENDOPT  -I. -I.  -DSSHDIR=\"/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/lib/openssh/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/lib/openssh/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/lib/openssh/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/lib/openssh/ssh-pkcs11-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/run/sshd\" -DSSH_RAND_HELPER=\"/usr/lib/openssh/ssh-rand-helper\" -DHAVE_CONFIG_H -c monitor_fdpass.c
monitor_fdpass.c: In function ‘mm_send_fd’:
monitor_fdpass.c:74: warning: dereferencing type-punned pointer will break strict-aliasing rules
monitor_fdpass.c: In function ‘mm_receive_fd’:
monitor_fdpass.c:175: warning: dereferencing type-punned pointer will break strict-aliasing rules

gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wno-pointer-sign -Wformat-security -fno-builtin-memset -fstack-protector-all -O2 -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -DLOGIN_PROGRAM=\"/bin/login\" -DLOGIN_NO_ENDOPT  -I. -I.  -DSSHDIR=\"/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/lib/openssh/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/lib/openssh/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/lib/openssh/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/lib/openssh/ssh-pkcs11-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/run/sshd\" -DSSH_RAND_HELPER=\"/usr/lib/openssh/ssh-rand-helper\" -DHAVE_CONFIG_H -c umac.c
umac.c: In function ‘pdf_gen_xor’:
umac.c:254: warning: dereferencing type-punned pointer will break strict-aliasing rules
umac.c:257: warning: dereferencing type-punned pointer will break strict-aliasing rules
umac.c:258: warning: dereferencing type-punned pointer will break strict-aliasing rules
umac.c:260: warning: dereferencing type-punned pointer will break strict-aliasing rules
umac.c:261: warning: dereferencing type-punned pointer will break strict-aliasing rules

gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wno-pointer-sign -Wformat-security -fno-builtin-memset -fstack-protector-all -O2 -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -DLOGIN_PROGRAM=\"/bin/login\" -DLOGIN_NO_ENDOPT  -I. -I.  -DSSHDIR=\"/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/lib/openssh/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/lib/openssh/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/lib/openssh/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/lib/openssh/ssh-pkcs11-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/run/sshd\" -DSSH_RAND_HELPER=\"/usr/lib/openssh/ssh-rand-helper\" -DHAVE_CONFIG_H -c schnorr.c
schnorr.c: In function ‘debug3_bn’:
schnorr.c:468: warning: ignoring return value of ‘vasprintf’, declared with attribute warn_unused_result
schnorr.c: In function ‘debug3_buf’:
schnorr.c:493: warning: ignoring return value of ‘vasprintf’, declared with attribute warn_unused_result

gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wno-pointer-sign -Wformat-security -fno-builtin-memset -fstack-protector-all -O2 -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -DLOGIN_PROGRAM=\"/bin/login\" -DLOGIN_NO_ENDOPT  -I. -I.  -DSSHDIR=\"/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/lib/openssh/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/lib/openssh/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/lib/openssh/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/lib/openssh/ssh-pkcs11-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/run/sshd\" -DSSH_RAND_HELPER=\"/usr/lib/openssh/ssh-rand-helper\" -DHAVE_CONFIG_H -c sshd.c
sshd.c: In function ‘main’:
sshd.c:1742: warning: ignoring return value of ‘chdir’, declared with attribute warn_unused_result

gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wno-pointer-sign -Wformat-security -fno-builtin-memset -fstack-protector-all -O2 -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -DLOGIN_PROGRAM=\"/bin/login\" -DLOGIN_NO_ENDOPT  -I. -I.  -DSSHDIR=\"/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/lib/openssh/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/lib/openssh/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/lib/openssh/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/lib/openssh/ssh-pkcs11-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/run/sshd\" -DSSH_RAND_HELPER=\"/usr/lib/openssh/ssh-rand-helper\" -DHAVE_CONFIG_H -c serverloop.c
serverloop.c: In function ‘notify_parent’:
serverloop.c:151: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result

gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wno-pointer-sign -Wformat-security -fno-builtin-memset -fstack-protector-all -O2 -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -DLOGIN_PROGRAM=\"/bin/login\" -DLOGIN_NO_ENDOPT  -I. -I.  -DSSHDIR=\"/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/lib/openssh/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/lib/openssh/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/lib/openssh/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/lib/openssh/ssh-pkcs11-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/run/sshd\" -DSSH_RAND_HELPER=\"/usr/lib/openssh/ssh-rand-helper\" -DHAVE_CONFIG_H -c ssh-agent.c
ssh-agent.c: In function ‘main’:
ssh-agent.c:1258: warning: ignoring return value of ‘chdir’, declared with attribute warn_unused_result

gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wno-pointer-sign -Wformat-security -fno-builtin-memset -fstack-protector-all -O2 -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -DLOGIN_PROGRAM=\"/bin/login\" -DLOGIN_NO_ENDOPT  -I. -I.  -DSSHDIR=\"/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/lib/openssh/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/lib/openssh/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/lib/openssh/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/lib/openssh/ssh-pkcs11-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/run/sshd\" -DSSH_RAND_HELPER=\"/usr/lib/openssh/ssh-rand-helper\" -DHAVE_CONFIG_H -c scp.c
scp.c: In function ‘lostconn’:
scp.c:1289: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result

gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wno-pointer-sign -Wformat-security -fno-builtin-memset -fstack-protector-all -O2 -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -DLOGIN_PROGRAM=\"/bin/login\" -DLOGIN_NO_ENDOPT  -I. -I.  -DSSHDIR=\"/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/lib/openssh/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/lib/openssh/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/lib/openssh/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/lib/openssh/ssh-pkcs11-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/run/sshd\" -DSSH_RAND_HELPER=\"/usr/lib/openssh/ssh-rand-helper\" -DHAVE_CONFIG_H -c ssh-rand-helper.c
ssh-rand-helper.c: In function ‘get_random_bytes_prngd’:
ssh-rand-helper.c:167: warning: dereferencing pointer ‘addr_in’ does break strict-aliasing rules
ssh-rand-helper.c:166: warning: dereferencing pointer ‘addr_in’ does break strict-aliasing rules
ssh-rand-helper.c:168: warning: dereferencing pointer ‘addr_in’ does break strict-aliasing rules
ssh-rand-helper.c:150: note: initialized from here
ssh-rand-helper.c:171: warning: dereferencing pointer ‘addr_un’ does break strict-aliasing rules
ssh-rand-helper.c:151: note: initialized from here

gcc -g -O2 -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wno-pointer-sign -Wformat-security -fno-builtin-memset -fstack-protector-all -O2 -fPIE -fstack-protector -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -DLOGIN_PROGRAM=\"/bin/login\" -DLOGIN_NO_ENDOPT  -I. -I.  -DSSHDIR=\"/etc/ssh\" -D_PATH_SSH_PROGRAM=\"/usr/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/lib/openssh/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/lib/openssh/sftp-server\" -D_PATH_SSH_KEY_SIGN=\"/usr/lib/openssh/ssh-keysign\" -D_PATH_SSH_PKCS11_HELPER=\"/usr/lib/openssh/ssh-pkcs11-helper\" -D_PATH_SSH_PIDDIR=\"/var/run\" -D_PATH_PRIVSEP_CHROOT_DIR=\"/var/run/sshd\" -DSSH_RAND_HELPER=\"/usr/lib/openssh/ssh-rand-helper\" -DHAVE_CONFIG_H -c sftp.c
sftp.c: In function ‘cmd_interrupt’:
sftp.c:219: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result


Thanks,

-- 
Colin Watson                                       [cjwatson at debian.org]