Call for testing: OpenSSH-5.4

Corinna Vinschen vinschen at redhat.com
Wed Mar 3 21:52:10 EST 2010


On Mar  3 13:23, Damien Miller wrote:
> On Tue, 2 Mar 2010, Iain Morgan wrote:
> 
> > On Tue, Mar 02, 2010 at 18:45:06 -0600, Damien Miller wrote:
> > > Thanks for the detailed test results! Darren fixed a portability bug in
> > > the test scripts on the weekend. Could you take a quick look at the start
> > > of regress/cert-hostkey.sh to see if it uses "echo -n" or "echon" in this
> > > block:
> > > 
> > > # Create a CA key and add it to known hosts
> > > ${SSHKEYGEN} -q -N '' -t rsa  -f $OBJ/host_ca_key ||\
> > >         fail "ssh-keygen of host_ca_key failed"
> > > (
> > >         echon '@cert-authority '
> > >         echon "$HOSTS "
> > >         cat $OBJ/host_ca_key.pub
> > > ) > $OBJ/known_hosts-cert
> > > 
> > > If it uses "echo -n" then you are using the version with the portability
> > > bug which will cause these tests to fail unexpectedly.
> > > 
> > 
> > The version of cert-hostkey.sh that I have been using (from the 20100302
> > snapshot) uses "echon" rather than "echo -n." However, I should note
> > that cert-userkey.sh still uses "echo -n", even in CVS.
> 
> oops, fixed now:
> 
> http://anoncvs.mindrot.org/index.cgi/openssh/regress/cert-userkey.sh?revision=1.2&view=markup

Just a question.  Why do you use slashes as separators, instead of
using the ISO 8601 format, as you already do in ssh-keygen.c, function
fmt_validity()?


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat


More information about the openssh-unix-dev mailing list