Call for testing: OpenSSH-5.4

[Damien Miller]

On Wed, 3 Mar 2010, Chris Adams wrote:

> Once upon a time, Damien Miller <djm at mindrot.org> said:
> > OpenSSH 5.4 is almost ready for release, so we would appreciate testing
> > on as many platforms and systems as possible. This is a big release,
> > with a number of major new features and many bug fixes.
> 
> Hmm, build of 20100304 fails on Tru64 (ignore the "long long" info
> messages):
> 
> cc: Error: ssh-keygen.c, line 1303: In this statement, "BSDoptarg" is not declared. (undeclared)
>                 fatal("Invalid certificate life specification %s", optarg);

Found the problem. The following patch will be in tomorrow's snapshot.

-d

Index: ssh-keygen.c
===================================================================
RCS file: /var/cvs/openssh/ssh-keygen.c,v
retrieving revision 1.193
diff -u -p -r1.193 ssh-keygen.c
--- ssh-keygen.c	3 Mar 2010 01:14:15 -0000	1.193
+++ ssh-keygen.c	4 Mar 2010 03:15:46 -0000
@@ -1300,7 +1300,7 @@ parse_cert_times(char *timespec)
 	from = xstrdup(timespec);
 	to = strchr(from, ':');
 	if (to == NULL || from == to || *(to + 1) == '\0')
-		fatal("Invalid certificate life specification %s", optarg);
+		fatal("Invalid certificate life specification %s", timespec);
 	*to++ = '\0';
 
 	if (*from == '-' || *from == '+')