Call for testing: OpenSSH-5.4

[Corinna Vinschen]

On Mar  4 22:06, Damien Miller wrote:
> 
> On Wed, 3 Mar 2010, Corinna Vinschen wrote:
> 
> > > > The version of cert-hostkey.sh that I have been using (from the 20100302
> > > > snapshot) uses "echon" rather than "echo -n." However, I should note
> > > > that cert-userkey.sh still uses "echo -n", even in CVS.
> > > 
> > > oops, fixed now:
> > > 
> > > http://anoncvs.mindrot.org/index.cgi/openssh/regress/cert-userkey.sh?revision=1.2&view=markup
> > 
> > Just a question.  Why do you use slashes as separators, instead of
> > using the ISO 8601 format, as you already do in ssh-keygen.c, function
> > fmt_validity()?
> 
> Did you mean "Why _don't_ you use slashes as separators"? Brevity of input
> mainly.

No, I meant to ask why you *use* slashes.  That's part of the new code:

1254       case 8:
1255               fmt = "%Y/%m/%d";
1256               snprintf(buf, sizeof(buf), "%.4s/%.2s/%.2s", s, s + 4,
1257               break;
1258       case 14:
1259               fmt = "%Y/%m/%d %H:%M:%S";
1260               snprintf(buf, sizeof(buf), "%.4s/%.2s/%.2s

I would opt for using the ISO 8601 format instead, just as it is
already done in fmt_validity:

1082  strftime(from, sizeof(from), "%Y-%m-%dT%H:%M:%S", tm);
[...]
1088  strftime(to, sizeof(to), "%Y-%m-%dT%H:%M:%S", tm);


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat