QoS marking for Openssh

[Philip A. Prindeville]

BTW:  there are certain options that should only appear "system-wide"
(i.e. in /etc/ssh/ssh_config or sshd_config)...  but should not be
allowed in ~/.ssh config files.

Should read_config_file() and process_config_line() take an extra
argument that specifies whether they are processing
_PATH_HOST_CONFIG_FILE or the user's config file?

Should "keywords[]" in readconf.c also contain a flag that tells us
whether this option is permissible in both the system-wide and per-user
profiles?



On 03/09/2010 05:49 PM, Damien Miller wrote:
> Thanks, could you please create an enhancement bug on
> https://bugzilla.mindrot.org and attach your patch there? I won't have a
> chance to do much OpenSSH hacking for a few weeks (after the mad rush of
> the release) so this will ensure that it doesn't get dropped.
>
> -d
>
> On Tue, 9 Mar 2010, Philip A. Prindeville wrote:
>
>   
>> Ok, so started banging on the code...
>>
>> Here's what I have.  I'll try out the client...
>>
>> If someone could test the server as well that would be great.
>>
>> Everything builds except ssh-keyscan, which apparently doesn't define
>> (or populate?) "options".
>>
>> Would be nice to not have to duplicate parse_qos().... is there someone
>> that we can put this and share it between readconf.o and servconf.o ? For that matter, it would be nice to have readconf.o and servconf.o be
>> able to share common code...
>>
>> Also wanted to update the documentation, but couldn't figure out what
>> the source file was that generates it...
>>
>> I'm thinking though that what when packet.o is linked with readconf.o,
>> then it should be:
>>
>> extern Options options;
>>
>> but when packet.o is linked with servconf.o, then it should be:
>>
>> extern ServerOptions options;
>>
>> am I wrong?
>>
>> Do I need to copy the value of options->use_qos[] into a static in
>> packet.c as:
>>
>> u_char qos[2];
>>
>> instead and use those?
>>
>> Thanks,
>>
>> -Philip
>>
>> P.S. Are you ever on IRC?  This might go quicker over IRC...  I'm
>> philipp64 on freenode.
>>
>>
>>
>>